From 1b7e5748e45fe5ce39b8eccc40b7eff292bd2ad8 Mon Sep 17 00:00:00 2001 From: Nicolas Coden Date: Thu, 1 Feb 2018 19:12:29 +0100 Subject: [PATCH] fix: remove window events handler when ResponsiveAccordionTabs is destroyed #10901 Closes https://github.com/zurb/foundation-sites/issues/10901 --- js/foundation.responsiveAccordionTabs.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/js/foundation.responsiveAccordionTabs.js b/js/foundation.responsiveAccordionTabs.js index 4ae87d81e..0ae378aaa 100644 --- a/js/foundation.responsiveAccordionTabs.js +++ b/js/foundation.responsiveAccordionTabs.js @@ -119,11 +119,8 @@ class ResponsiveAccordionTabs extends Plugin{ * @private */ _events() { - var _this = this; - - $(window).on('changed.zf.mediaquery', function() { - _this._checkMediaQueries(); - }); + this._changedZfMediaQueryHandler = this._checkMediaQueries.bind(this); + $(window).on('changed.zf.mediaquery', this._changedZfMediaQueryHandler); } /** @@ -234,7 +231,7 @@ class ResponsiveAccordionTabs extends Plugin{ */ _destroy() { if (this.currentPlugin) this.currentPlugin.destroy(); - $(window).off('.zf.ResponsiveAccordionTabs'); + $(window).off('changed.zf.mediaquery', this._changedZfMediaQueryHandler); } } -- 2.47.2