From 2bd3bd0e318f19008e9fe068ab17277c530ffb92 Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Fri, 17 May 2024 09:39:52 +0200 Subject: [PATCH] http: fix nul deref on memcap reached HttpRangeOpenFileAux may return NULL in different cases, including when memcap is reached. But is only caller did not check it before calling HttpRangeAppendData which would dereference the NULL value. Ticket: 7029 (cherry picked from commit fd262df457f67f2174752dd6505ba2ed5911fd96) --- src/app-layer-htp-range.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app-layer-htp-range.c b/src/app-layer-htp-range.c index 3cdde35ba2..f0d75a9750 100644 --- a/src/app-layer-htp-range.c +++ b/src/app-layer-htp-range.c @@ -351,8 +351,10 @@ static HttpRangeContainerBlock *HttpRangeOpenFile(HttpRangeContainerFile *c, uin { HttpRangeContainerBlock *r = HttpRangeOpenFileAux(c, start, end, total, sbcfg, name, name_len, flags); - if (HttpRangeAppendData(sbcfg, r, data, len) < 0) { - SCLogDebug("Failed to append data while opening"); + if (r) { + if (HttpRangeAppendData(sbcfg, r, data, len) < 0) { + SCLogDebug("Failed to append data while opening"); + } } return r; } -- 2.47.2