From d8b072c532bb696a69bc00a4f98a49263cfe53dd Mon Sep 17 00:00:00 2001 From: SassNinja Date: Fri, 25 Oct 2019 09:28:35 +0200 Subject: [PATCH] perf: cache chars length in GetYoDigits This improves performance in particular for older browsers. --- js/foundation.core.utils.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/js/foundation.core.utils.js b/js/foundation.core.utils.js index 4c6893eb2..f9d04b392 100644 --- a/js/foundation.core.utils.js +++ b/js/foundation.core.utils.js @@ -22,8 +22,9 @@ function rtl() { function GetYoDigits(length = 6, namespace){ let str = ''; const chars = '0123456789abcdefghijklmnopqrstuvwxyz'; + const charsLength = chars.length; for (let i = 0; i < length; i++) { - str += chars[Math.floor(Math.random() * chars.length)]; + str += chars[Math.floor(Math.random() * charsLength)]; } return namespace ? `${str}-${namespace}` : str; } -- 2.47.2