From 3c66c1fec7ce4edeff284a5e4abe32d0b4398539 Mon Sep 17 00:00:00 2001 From: Nikhil Benesch Date: Wed, 22 Dec 2021 18:58:17 -0500 Subject: [PATCH] Remove unnecessary flag in macOS build The configuration logic for adding the `-search_paths_first` linker flag on Darwin does not correctly handle cross compilation. It should check the value of $krb5_cv_host rather than `uname -s` to detect when the compilation target is Darwin, rather than the build machine. It turns out `-search_paths_first` has been the default behavior of ld on macOS since XCode 4. So just remove that bit of logic entirely. (The flag was added in commit acd27af0e845f8b93de2e226cc2ec9ac8af52077 in 2004; XCode 4 was released in 2010.) [ghudson@mit.edu: edited commit message] --- src/aclocal.m4 | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/aclocal.m4 b/src/aclocal.m4 index 0ea4d18930..9920476f91 100644 --- a/src/aclocal.m4 +++ b/src/aclocal.m4 @@ -595,10 +595,6 @@ if test "$GCC" = yes ; then CFLAGS="$CFLAGS -fno-common" ;; esac - case "$LD $LDFLAGS" in - *-Wl,-search_paths_first*) ;; - *) LDFLAGS="${LDFLAGS} -Wl,-search_paths_first" ;; - esac fi else if test "`uname -s`" = AIX ; then -- 2.47.2