From b16679d8406ba5084ccdf330c080f296edd0239c Mon Sep 17 00:00:00 2001 From: Jorge Pereira Date: Thu, 17 Sep 2015 09:45:47 -0300 Subject: [PATCH] if try to load a wrong client from SQL, don't start --- src/modules/rlm_sql/rlm_sql.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/rlm_sql/rlm_sql.c b/src/modules/rlm_sql/rlm_sql.c index e1e18c9c31..f9358ad52f 100644 --- a/src/modules/rlm_sql/rlm_sql.c +++ b/src/modules/rlm_sql/rlm_sql.c @@ -272,6 +272,7 @@ static int generate_sql_clients(rlm_sql_t *inst) rlm_sql_handle_t *handle; rlm_sql_row_t row; unsigned int i = 0; + int ret = 0; RADCLIENT *c; DEBUG("rlm_sql (%s): Processing generate_sql_clients", @@ -340,7 +341,8 @@ static int generate_sql_clients(rlm_sql_t *inst) WARN("Failed to add client, possible duplicate?"); client_free(c); - continue; + ret = -1; + break; } DEBUG("rlm_sql (%s): Client \"%s\" (%s) added", c->longname, c->shortname, @@ -350,7 +352,7 @@ static int generate_sql_clients(rlm_sql_t *inst) (inst->module->sql_finish_select_query)(handle, inst->config); fr_connection_release(inst->pool, handle); - return 0; + return ret; } -- 2.47.2