From 917c9cab31afc75b7e6899976c48ddd534c61e30 Mon Sep 17 00:00:00 2001 From: Yusuf Simonson Date: Sat, 7 Mar 2015 12:34:37 -0500 Subject: [PATCH] Prevent bad calls to get_arguments with a presumed default value --- tornado/web.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tornado/web.py b/tornado/web.py index f4e8a84aa..6d37f7050 100644 --- a/tornado/web.py +++ b/tornado/web.py @@ -392,6 +392,12 @@ class RequestHandler(object): The returned values are always unicode. """ + + # Make sure `get_arguments` isn't accidentally being called with a + # positional argument that's assumed to be a default (like in + # `get_argument`.) + assert isinstance(strip, bool) + return self._get_arguments(name, self.request.arguments, strip) def get_body_argument(self, name, default=_ARG_DEFAULT, strip=True): -- 2.47.2