From 9d7db08c1ea0d9ed0a02ef598bde3e60c4ef3297 Mon Sep 17 00:00:00 2001
From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Fri, 19 Jan 2024 15:26:21 +0100
Subject: [PATCH] getAllDomains catalog: avoid useless copy

---
 pdns/backends/gsql/gsqlbackend.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
index ce14715678..8ebb3c8acf 100644
--- a/pdns/backends/gsql/gsqlbackend.cc
+++ b/pdns/backends/gsql/gsqlbackend.cc
@@ -1759,7 +1759,9 @@ void GSQLBackend::getAllDomains(vector<DomainInfo>* domains, bool getSerial, boo
       pdns::checked_stoi_into(di.id, row[0]);
       try {
         di.zone = DNSName(row[1]);
-        di.catalog = (!row[8].empty() ? DNSName(row[8]) : DNSName());
+        if (!row[8].empty()) {
+          di.catalog = DNSName(row[8]);
+        }
       } catch (...) {
         continue;
       }
-- 
2.47.2