From 13ff94db36cd045daf06c45d752f04699a8a0304 Mon Sep 17 00:00:00 2001 From: Daan De Meyer Date: Mon, 13 Mar 2023 11:30:48 +0100 Subject: [PATCH] Always pass credentials as base64 encoded Avoid qemu command line shenanigans by just always passing base64 encoded binary credentials. --- mkosi/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mkosi/__init__.py b/mkosi/__init__.py index afea77673..2730a2289 100644 --- a/mkosi/__init__.py +++ b/mkosi/__init__.py @@ -1,6 +1,7 @@ # SPDX-License-Identifier: LGPL-2.1+ import argparse +import base64 import configparser import contextlib import crypt @@ -3678,7 +3679,7 @@ def run_qemu(config: MkosiConfig) -> None: cmdline += ["-drive", f"if=pflash,format=raw,readonly=on,file={firmware}"] for k, v in config.credentials.items(): - cmdline += ["-smbios", f"type=11,value=io.systemd.credential:{k}={v}"] + cmdline += ["-smbios", f"type=11,value=io.systemd.credential.binary:{k}={base64.b64encode(v.encode()).decode()}"] for v in config.qemu_smbios: cmdline += ["-smbios", f"type=11,value={v}"] -- 2.47.2