From 9b91f970ae5b9e654ce89b2eb477273fb0907153 Mon Sep 17 00:00:00 2001 From: Matthew Newton Date: Thu, 26 Nov 2015 11:24:44 +0000 Subject: [PATCH] SoH isn't very useful without attributes Broken in c11e3d8454 by no longer setting fake->packet->vps. eapsoh_verify has no need to see the original request as long as it's got access to the data to parse, so just pass in the fake request and get the attributes created there directly. --- doc/ChangeLog | 1 + src/modules/rlm_eap/types/rlm_eap_peap/peap.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/ChangeLog b/doc/ChangeLog index 6a08d5739a..52e302c7ab 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -34,6 +34,7 @@ FreeRADIUS 3.0.11 Mon 05 Oct 2015 15:00:00 EDT urgency=medium * Fixed bug with radmin related to the option "stats detail " * Complain if the detail file reader does not have permission to read the "detail.work" file. Fixes #1398 + * Fixed SoH. Attributes were not being copied to the virtual server. FreeRADIUS 3.0.10 Mon 05 Oct 2015 15:00:00 EDT urgency=medium Feature improvements diff --git a/src/modules/rlm_eap/types/rlm_eap_peap/peap.c b/src/modules/rlm_eap/types/rlm_eap_peap/peap.c index bdb11d6156..79c30d11ab 100644 --- a/src/modules/rlm_eap/types/rlm_eap_peap/peap.c +++ b/src/modules/rlm_eap/types/rlm_eap_peap/peap.c @@ -804,7 +804,7 @@ rlm_rcode_t eappeap_process(eap_handler_t *handler, tls_session_t *tls_session) case PEAP_STATUS_WAIT_FOR_SOH_RESPONSE: fake = request_alloc_fake(request); rad_assert(!fake->packet->vps); - eapsoh_verify(request, fake->packet, data, data_len); + eapsoh_verify(fake, fake->packet, data, data_len); setup_fake_request(request, fake, t); if (t->soh_virtual_server) { -- 2.47.2