From 48971afdfb8f8400956a9f11867005ef8e0ad470 Mon Sep 17 00:00:00 2001 From: David Maciejak Date: Sun, 8 Feb 2015 10:27:03 +0800 Subject: [PATCH] Fix Unit ID check --- src/app-layer-modbus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app-layer-modbus.c b/src/app-layer-modbus.c index 873423184a..6442b821e9 100644 --- a/src/app-layer-modbus.c +++ b/src/app-layer-modbus.c @@ -451,8 +451,8 @@ static void ModbusCheckHeader(ModbusState *modbus, ModbusSetEvent(modbus, MODBUS_DECODER_EVENT_INVALID_LENGTH); /* Check Unit Identifier field that is not in invalid range */ - if ((header->length > MODBUS_MIN_INVALID_UNIT_ID) && - (header->length < MODBUS_MAX_INVALID_UNIT_ID) ) + if ((header->unitId > MODBUS_MIN_INVALID_UNIT_ID) && + (header->unitId < MODBUS_MAX_INVALID_UNIT_ID) ) ModbusSetEvent(modbus, MODBUS_DECODER_EVENT_INVALID_UNIT_IDENTIFIER); SCReturn; -- 2.47.2