From 77ef7847f7e531acc6626204a628e1969301d021 Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Mon, 24 Dec 2018 08:48:04 -0600 Subject: [PATCH] Improve setting the default build type The CMAKE_BUILD_TYPE variable is a CACHE variable and should be set in a way that persists and is documented in the CACHE. Also set the default values for the gui to ease selection of types. These changes provide better support for GUI configurators that support cmake. --- build/cmake/CMakeLists.txt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/build/cmake/CMakeLists.txt b/build/cmake/CMakeLists.txt index c9dab0d5d..d0f943b58 100644 --- a/build/cmake/CMakeLists.txt +++ b/build/cmake/CMakeLists.txt @@ -12,9 +12,12 @@ cmake_minimum_required(VERSION 2.8.9) project(zstd) set(ZSTD_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../..") -if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) - message(STATUS "No build type selected, defaulting to Release") - set(CMAKE_BUILD_TYPE "Release") +# Set a default build type if none was specified +if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) + message(STATUS "Setting build type to 'Release' as none was specified.") + set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE) + # Set the possible values of build type for cmake-gui + set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS "Debug" "Release" "MinSizeRel" "RelWithDebInfo") endif() list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/CMakeModules") -- 2.47.2