From 47c61d9e00e5d0501605e131b71f4d1c292d4bde Mon Sep 17 00:00:00 2001 From: Miod Vallat Date: Thu, 12 Jun 2025 09:37:05 +0200 Subject: [PATCH] Drop domainid argument from DNSSECKeeper::startTransaction. It is never used in a destructive way. --- pdns/dnsseckeeper.hh | 4 ++-- pdns/pdnsutil.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pdns/dnsseckeeper.hh b/pdns/dnsseckeeper.hh index c454a1d714..7b5614f792 100644 --- a/pdns/dnsseckeeper.hh +++ b/pdns/dnsseckeeper.hh @@ -223,9 +223,9 @@ public: bool TSIGGrantsAccess(const ZoneName& zone, const DNSName& keyname); bool getTSIGForAccess(const ZoneName& zone, const ComboAddress& primary, DNSName* keyname); - void startTransaction(const ZoneName& zone, domainid_t zone_id) + void startTransaction(const ZoneName& zone) { - (*d_keymetadb->backends.begin())->startTransaction(zone, zone_id); + (*d_keymetadb->backends.begin())->startTransaction(zone); } void commitTransaction() diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc index 6c51069658..ec90472462 100644 --- a/pdns/pdnsutil.cc +++ b/pdns/pdnsutil.cc @@ -3442,7 +3442,7 @@ static int secureZone(vector& cmds, const std::string_view synopsis) unsigned int zoneErrors=0; for(unsigned int n = 1; n < cmds.size(); ++n) { // NOLINT(readability-identifier-length) ZoneName zone(cmds.at(n)); - dk.startTransaction(zone, UnknownDomainID); + dk.startTransaction(zone); if(secureZone(dk, zone)) { mustRectify.push_back(std::move(zone)); } else { -- 2.47.2