From 9ca3a5c9f17126d8a2850bf41a457f31f08f4df1 Mon Sep 17 00:00:00 2001 From: Miod Vallat Date: Mon, 23 Jun 2025 10:27:52 +0200 Subject: [PATCH] Close race window during which various flag values might be incorrect. Signed-off-by: Miod Vallat --- modules/lmdbbackend/lmdbbackend.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc index a28eac0045..4433462c25 100644 --- a/modules/lmdbbackend/lmdbbackend.cc +++ b/modules/lmdbbackend/lmdbbackend.cc @@ -685,8 +685,6 @@ LMDBBackend::LMDBBackend(const std::string& suffix) string syncMode = toLower(getArg("sync-mode")); - d_random_ids = mustDo("random-ids"); - if (syncMode == "nosync") d_asyncFlag = MDB_NOSYNC; else if (syncMode == "nometasync") @@ -704,9 +702,6 @@ LMDBBackend::LMDBBackend(const std::string& suffix) throw std::runtime_error(std::string("Unable to parse the 'map-size' LMDB value: ") + e.what()); } - LMDBLS::s_flag_deleted = mustDo("flag-deleted"); - d_handle_dups = false; - if (mustDo("lightning-stream")) { d_random_ids = true; d_handle_dups = true; @@ -716,6 +711,11 @@ LMDBBackend::LMDBBackend(const std::string& suffix) throw std::runtime_error(std::string("running with Lightning Stream support requires shards=1")); } } + else { + d_random_ids = mustDo("random-ids"); + d_handle_dups = false; + LMDBLS::s_flag_deleted = mustDo("flag-deleted"); + } bool opened = false; -- 2.47.2