From 2a3f048c4cd788fa8fb82e0bd16c365e070b2107 Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Wed, 2 Jul 2025 09:39:20 +0200 Subject: [PATCH] Also use new dns_random(void *, size_t) for client cookie Signed-off-by: Otto Moerbeek --- pdns/ednscookies.cc | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/pdns/ednscookies.cc b/pdns/ednscookies.cc index c390865ef7..96178998f1 100644 --- a/pdns/ednscookies.cc +++ b/pdns/ednscookies.cc @@ -148,12 +148,9 @@ bool EDNSCookiesOpt::shouldRefresh() const void EDNSCookiesOpt::makeClientCookie() { - uint32_t lower = dns_random_uint32(); - uint32_t upper = dns_random_uint32(); - client = string(); - client.resize(sizeof(lower) + sizeof(upper)); - memcpy(client.data(), &lower, sizeof(lower)); - memcpy(&client.at(sizeof(lower)), &upper, sizeof(upper)); + const size_t clientCookieSize = 8; + client.resize(clientCookieSize); + dns_random(client.data(), clientCookieSize); } bool EDNSCookiesOpt::makeServerCookie([[maybe_unused]] const string& secret, [[maybe_unused]] const ComboAddress& source) -- 2.47.2