From 9c75c855c6bba0e9ef9facc7c948612cd0c2a855 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 23 Feb 2015 22:41:08 -0800 Subject: [PATCH] JS unit tests: equal() => strictEqual() [skip validator] --- js/tests/unit/alert.js | 4 +-- js/tests/unit/button.js | 24 +++++++------- js/tests/unit/carousel.js | 6 ++-- js/tests/unit/collapse.js | 12 +++---- js/tests/unit/popover.js | 32 +++++++++--------- js/tests/unit/tab.js | 32 +++++++++--------- js/tests/unit/tooltip.js | 70 +++++++++++++++++++-------------------- 7 files changed, 90 insertions(+), 90 deletions(-) diff --git a/js/tests/unit/alert.js b/js/tests/unit/alert.js index 5e275584ab..dc9235c774 100644 --- a/js/tests/unit/alert.js +++ b/js/tests/unit/alert.js @@ -38,7 +38,7 @@ $(function () { $alert.find('.close').click() - assert.equal($alert.hasClass('in'), false, 'remove .in class on .close click') + assert.strictEqual($alert.hasClass('in'), false, 'remove .in class on .close click') }) QUnit.test('should remove element when clicking .close', function (assert) { @@ -52,7 +52,7 @@ $(function () { $alert.find('.close').click() - assert.equal($('#qunit-fixture').find('.alert').length, 0, 'element removed from dom') + assert.strictEqual($('#qunit-fixture').find('.alert').length, 0, 'element removed from dom') }) QUnit.test('should not fire closed when close is prevented', function (assert) { diff --git a/js/tests/unit/button.js b/js/tests/unit/button.js index 0d708d10d2..d173916a0c 100644 --- a/js/tests/unit/button.js +++ b/js/tests/unit/button.js @@ -31,11 +31,11 @@ $(function () { QUnit.test('should return set state to loading', function (assert) { var $btn = $('') - assert.equal($btn.html(), 'mdo', 'btn text equals mdo') + assert.strictEqual($btn.html(), 'mdo', 'btn text equals mdo') $btn.bootstrapButton('loading') var done = assert.async() setTimeout(function () { - assert.equal($btn.html(), 'fat', 'btn text equals fat') + assert.strictEqual($btn.html(), 'fat', 'btn text equals fat') assert.ok($btn[0].hasAttribute('disabled'), 'btn is disabled') assert.ok($btn.hasClass('disabled'), 'btn has disabled class') done() @@ -44,18 +44,18 @@ $(function () { QUnit.test('should return reset state', function (assert) { var $btn = $('') - assert.equal($btn.html(), 'mdo', 'btn text equals mdo') + assert.strictEqual($btn.html(), 'mdo', 'btn text equals mdo') $btn.bootstrapButton('loading') var doneOne = assert.async() setTimeout(function () { - assert.equal($btn.html(), 'fat', 'btn text equals fat') + assert.strictEqual($btn.html(), 'fat', 'btn text equals fat') assert.ok($btn[0].hasAttribute('disabled'), 'btn is disabled') assert.ok($btn.hasClass('disabled'), 'btn has disabled class') doneOne() var doneTwo = assert.async() $btn.bootstrapButton('reset') setTimeout(function () { - assert.equal($btn.html(), 'mdo', 'btn text equals mdo') + assert.strictEqual($btn.html(), 'mdo', 'btn text equals mdo') assert.ok(!$btn[0].hasAttribute('disabled'), 'btn is not disabled') assert.ok(!$btn.hasClass('disabled'), 'btn does not have disabled class') doneTwo() @@ -65,18 +65,18 @@ $(function () { QUnit.test('should work with an empty string as reset state', function (assert) { var $btn = $('') - assert.equal($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') + assert.strictEqual($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') $btn.bootstrapButton('toggle') - assert.equal($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') + assert.strictEqual($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') }) QUnit.test('should toggle aria-pressed when btn children are clicked', function (assert) { @@ -115,9 +115,9 @@ $(function () { $btn .append($inner) .appendTo('#qunit-fixture') - assert.equal($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') + assert.strictEqual($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') $inner.click() - assert.equal($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') + assert.strictEqual($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') }) QUnit.test('should toggle active when btn children are clicked within btn-group', function (assert) { diff --git a/js/tests/unit/carousel.js b/js/tests/unit/carousel.js index e0ed4f89b6..2044b14089 100644 --- a/js/tests/unit/carousel.js +++ b/js/tests/unit/carousel.js @@ -327,19 +327,19 @@ $(function () { $carousel.appendTo('body') $('[data-slide]').first().click() - assert.equal($carousel.data('bs.carousel').options.interval, 1814) + assert.strictEqual($carousel.data('bs.carousel').options.interval, 1814) $carousel.remove() $carousel.appendTo('body').attr('data-modal', 'foobar') $('[data-slide]').first().click() - assert.equal($carousel.data('bs.carousel').options.interval, 1814, 'even if there is an data-modal attribute set') + assert.strictEqual($carousel.data('bs.carousel').options.interval, 1814, 'even if there is an data-modal attribute set') $carousel.remove() $carousel.appendTo('body') $('[data-slide]').first().click() $carousel.attr('data-interval', 1860) $('[data-slide]').first().click() - assert.equal($carousel.data('bs.carousel').options.interval, 1814, 'attributes should be read only on initialization') + assert.strictEqual($carousel.data('bs.carousel').options.interval, 1814, 'attributes should be read only on initialization') $carousel.remove() $carousel.attr('data-interval', false) diff --git a/js/tests/unit/collapse.js b/js/tests/unit/collapse.js index 22ae827ce4..1616fe48b0 100644 --- a/js/tests/unit/collapse.js +++ b/js/tests/unit/collapse.js @@ -63,7 +63,7 @@ $(function () { $('
') .on('show.bs.collapse', function () { - assert.equal(this.style.height, '0px', 'height is 0px') + assert.strictEqual(this.style.height, '0px', 'height is 0px') }) .on('shown.bs.collapse', function () { assert.strictEqual(this.style.height, '', 'height is auto') @@ -208,7 +208,7 @@ $(function () { $('
') .appendTo('#qunit-fixture') .on('shown.bs.collapse', function () { - assert.equal($target.attr('aria-expanded'), 'true', 'aria-expanded on target is "true"') + assert.strictEqual($target.attr('aria-expanded'), 'true', 'aria-expanded on target is "true"') done() }) @@ -223,7 +223,7 @@ $(function () { $('
') .appendTo('#qunit-fixture') .on('hidden.bs.collapse', function () { - assert.equal($target.attr('aria-expanded'), 'false', 'aria-expanded on target is "false"') + assert.strictEqual($target.attr('aria-expanded'), 'false', 'aria-expanded on target is "false"') done() }) @@ -253,9 +253,9 @@ $(function () { $('