From ac61a8616b89ae9aa4f9fa927c7be659a19901b5 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sat, 8 Nov 2025 19:23:43 -0500 Subject: [PATCH] chore: Use finally for cleanup Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../test_Protobuf.py | 29 ++++++++++--------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/regression-tests.recursor-dnssec/test_Protobuf.py b/regression-tests.recursor-dnssec/test_Protobuf.py index 1d31e6c025..857f27b8eb 100644 --- a/regression-tests.recursor-dnssec/test_Protobuf.py +++ b/regression-tests.recursor-dnssec/test_Protobuf.py @@ -46,19 +46,22 @@ def ProtobufListener(queue, port): sys.exit(1) sock.listen(100) - while True: - try: - (conn, _) = sock.accept() - thread = threading.Thread(name='Connection Handler', - target=ProtobufConnectionHandler, - args=[queue, conn]) - thread.daemon = True - thread.start() - - except socket.error as e: - print('Error in protobuf socket: %s' % str(e)) - - sock.close() + + try: + while True: + try: + (conn, _) = sock.accept() + thread = threading.Thread(name='Connection Handler', + target=ProtobufConnectionHandler, + args=[queue, conn]) + thread.daemon = True + thread.start() + + except socket.error as e: + print('Error in protobuf socket: %s' % str(e)) + + finally: + sock.close() class ProtobufServerParams: -- 2.47.3