From f88887547898553fd9920b826fdaafbc78a94c07 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 4 Dec 2025 09:10:25 -0500 Subject: [PATCH] Promtool may return 3 because of the "_total" suffix warnings Co-authored-by: Miod Vallat Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- regression-tests.dnsdist/test_Prometheus.py | 2 +- regression-tests.ixfrdist/test_Stats.py | 2 +- regression-tests.recursor-dnssec/test_Prometheus.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/regression-tests.dnsdist/test_Prometheus.py b/regression-tests.dnsdist/test_Prometheus.py index b41ce956b8..57e5cc0657 100644 --- a/regression-tests.dnsdist/test_Prometheus.py +++ b/regression-tests.dnsdist/test_Prometheus.py @@ -94,7 +94,7 @@ class TestPrometheus(DNSDistTest): except subprocess.CalledProcessError as exc: raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output)) - # promtool returns 3 because of the "_total" suffix warnings + # promtool may return 3 because of the "_total" suffix warnings if not process.returncode in [0, 3]: raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output)) diff --git a/regression-tests.ixfrdist/test_Stats.py b/regression-tests.ixfrdist/test_Stats.py index a8d4e69d41..bc1bf3d74d 100644 --- a/regression-tests.ixfrdist/test_Stats.py +++ b/regression-tests.ixfrdist/test_Stats.py @@ -60,7 +60,7 @@ webserver-address: %s except subprocess.CalledProcessError as exc: raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output)) - # promtool returns 3 because of the "_total" suffix warnings + # promtool may return 3 because of the "_total" suffix warnings if not process.returncode in [0, 3]: raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output)) diff --git a/regression-tests.recursor-dnssec/test_Prometheus.py b/regression-tests.recursor-dnssec/test_Prometheus.py index a618ae4db4..d826fd3105 100644 --- a/regression-tests.recursor-dnssec/test_Prometheus.py +++ b/regression-tests.recursor-dnssec/test_Prometheus.py @@ -29,7 +29,7 @@ class RecPrometheusTest(RecursorTest): except subprocess.CalledProcessError as exc: raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output)) - # promtool returns 3 because of the "_total" suffix warnings + # promtool may return 3 because of the "_total" suffix warnings if not process.returncode in [0, 3]: raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output)) -- 2.47.3