From 6788af3df862c18b0d086474b250346caa759de5 Mon Sep 17 00:00:00 2001 From: Miod Vallat Date: Fri, 12 Dec 2025 14:22:01 +0100 Subject: [PATCH] Address Coverity reported unnecessary object copies. Signed-off-by: Miod Vallat --- modules/geoipbackend/geoipbackend.cc | 2 +- pdns/auth-secondarycommunicator.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/geoipbackend/geoipbackend.cc b/modules/geoipbackend/geoipbackend.cc index 0c4f90027f..998b12ec56 100644 --- a/modules/geoipbackend/geoipbackend.cc +++ b/modules/geoipbackend/geoipbackend.cc @@ -302,7 +302,7 @@ bool GeoIPBackend::loadDomain(const std::string& origin, const YAML::Node& domai rr.weight = 100; } rr.auth = true; - rrs.push_back(rr); + rrs.push_back(std::move(rr)); } std::swap(dom.records[qname.operator const DNSName&()], rrs); } diff --git a/pdns/auth-secondarycommunicator.cc b/pdns/auth-secondarycommunicator.cc index eb17c85508..b0153eb5bb 100644 --- a/pdns/auth-secondarycommunicator.cc +++ b/pdns/auth-secondarycommunicator.cc @@ -412,7 +412,7 @@ static bool catalogProcess(const XFRContext& ctx, vector& rrs if (content.length() >= 2 && content.at(0) == '\"' && content.at(content.length() - 1) == '\"') { // TXT pain content = content.substr(1, content.length() - 2); } - ci.d_group.insert(content); + ci.d_group.insert(std::move(content)); } } } @@ -556,7 +556,7 @@ static bool processRecordForZS(const DNSName& domain, bool& firstNSEC3, DNSResou ctx.optOutFlag = static_cast(ns3rc.d_flags & 1); if (ns3rc.isSet(QType::NS) && !(rr.qname == domain)) { DNSName hashPart = rr.qname.makeRelative(domain); - ctx.secured.insert(hashPart); + ctx.secured.insert(std::move(hashPart)); } return false; } -- 2.47.3