From b3a61c42660ed301b6ff3fcd0f64af9ba96964c2 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Mon, 19 Jan 2026 12:13:19 +0100 Subject: [PATCH] dnsdist: Fix small perf issues reported by Coverity Signed-off-by: Remi Gacogne --- pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc | 6 +++--- pdns/dnsdistdist/dnsdist-web.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc b/pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc index 56a96b5152..219366db91 100644 --- a/pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc +++ b/pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc @@ -327,14 +327,14 @@ void setupLuaBindingsDNSQuestion([[maybe_unused]] LuaContext& luaCtx) } ede.clearExisting = clearExistingEntries.value_or(true); if (ede.clearExisting) { - dnsQuestion.ids.d_extendedErrors = std::make_unique>(std::initializer_list({ede})); + dnsQuestion.ids.d_extendedErrors = std::make_unique>(std::initializer_list({std::move(ede)})); } else { if (!dnsQuestion.ids.d_extendedErrors) { - dnsQuestion.ids.d_extendedErrors = std::make_unique>(std::initializer_list({ede})); + dnsQuestion.ids.d_extendedErrors = std::make_unique>(std::initializer_list({std::move(ede)})); } else { - dnsQuestion.ids.d_extendedErrors->emplace_back(ede); + dnsQuestion.ids.d_extendedErrors->emplace_back(std::move(ede)); } } }); diff --git a/pdns/dnsdistdist/dnsdist-web.cc b/pdns/dnsdistdist/dnsdist-web.cc index 836d3d3f23..f122d52fce 100644 --- a/pdns/dnsdistdist/dnsdist-web.cc +++ b/pdns/dnsdistdist/dnsdist-web.cc @@ -494,7 +494,7 @@ static void handlePrometheus(const YaHTTP::Request& req, YaHTTP::Response& resp) std::ostringstream output; std::string instanceLabel; // MUST be empty when instance label is not requested { - auto rtc = dnsdist::configuration::getCurrentRuntimeConfiguration(); + const auto& rtc = dnsdist::configuration::getCurrentRuntimeConfiguration(); instanceLabel = rtc.d_prometheusAddInstanceLabel ? "instance=\"" + rtc.d_server_id + "\"" : ""; } static const std::set metricBlacklist = {"special-memory-usage", "latency-count", "latency-sum"}; -- 2.47.3