From af54d8e68bfe5d85feb7ba5366084b5d3c3792ae Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Wed, 11 Oct 2017 12:13:08 +0200 Subject: [PATCH] tests: test container live patching Signed-off-by: Christian Brauner --- .gitignore | 1 + src/lxc/lxccontainer.c | 2 +- src/tests/Makefile.am | 4 +- src/tests/livepatch.c | 256 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 261 insertions(+), 2 deletions(-) create mode 100644 src/tests/livepatch.c diff --git a/.gitignore b/.gitignore index 80f6889b7..3930b11fa 100644 --- a/.gitignore +++ b/.gitignore @@ -84,6 +84,7 @@ src/tests/lxc-test-destroytest src/tests/lxc-test-get_item src/tests/lxc-test-getkeys src/tests/lxc-test-list +src/tests/lxc-test-livepatch src/tests/lxc-test-locktests src/tests/lxc-test-lxcpath src/tests/lxc-test-may-control diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 2df8c183e..06b90802d 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -2838,7 +2838,7 @@ static bool do_lxcapi_set_running_config_item(struct lxc_container *c, const cha ret = lxc_cmd_set_config_item(c->name, key, v, do_lxcapi_get_config_path(c)); if (ret < 0) - ERROR("Failed to live patch container"); + SYSERROR("%s - Failed to live patch container", strerror(-ret)); container_mem_unlock(c); return ret == 0; diff --git a/src/tests/Makefile.am b/src/tests/Makefile.am index 59a52b737..1fd58b2cb 100644 --- a/src/tests/Makefile.am +++ b/src/tests/Makefile.am @@ -27,6 +27,7 @@ lxc_test_utils_SOURCES = lxc-test-utils.c lxctest.h lxc_test_parse_config_file_SOURCES = parse_config_file.c lxctest.h lxc_test_config_jump_table_SOURCES = config_jump_table.c lxctest.h lxc_test_shortlived_SOURCES = shortlived.c +lxc_test_livepatch_SOURCES = livepatch.c lxctest.h AM_CFLAGS=-DLXCROOTFSMOUNT=\"$(LXCROOTFSMOUNT)\" \ -DLXCPATH=\"$(LXCPATH)\" \ @@ -55,7 +56,7 @@ bin_PROGRAMS = lxc-test-containertests lxc-test-locktests lxc-test-startone \ lxc-test-snapshot lxc-test-concurrent lxc-test-may-control \ lxc-test-reboot lxc-test-list lxc-test-attach lxc-test-device-add-remove \ lxc-test-apparmor lxc-test-utils lxc-test-parse-config-file \ - lxc-test-config-jump-table lxc-test-shortlived + lxc-test-config-jump-table lxc-test-shortlived lxc-test-livepatch bin_SCRIPTS = lxc-test-automount \ lxc-test-autostart \ @@ -91,6 +92,7 @@ EXTRA_DIST = \ get_item.c \ getkeys.c \ list.c \ + livepatch.c \ locktests.c \ lxcpath.c \ lxc-test-lxc-attach \ diff --git a/src/tests/livepatch.c b/src/tests/livepatch.c new file mode 100644 index 000000000..7189cb36c --- /dev/null +++ b/src/tests/livepatch.c @@ -0,0 +1,256 @@ +/* liblxcapi + * + * Copyright © 2017 Christian Brauner . + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2, as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#include "lxctest.h" + +int main(int argc, char *argv[]) +{ + char *value; + struct lxc_container *c; + int ret = EXIT_FAILURE; + + c = lxc_container_new("livepatch", NULL); + if (!c) { + lxc_error("%s", "Failed to create container \"livepatch\""); + exit(ret); + } + + if (c->is_defined(c)) { + lxc_error("%s\n", "Container \"livepatch\" is defined"); + goto on_error_put; + } + + if (!c->set_config_item(c, "lxc.net.0.type", "veth")) { + lxc_error("%s\n", "Failed to set network item \"lxc.net.0.type\""); + goto on_error_put; + } + + if (!c->set_config_item(c, "lxc.net.0.link", "lxcbr0")) { + lxc_error("%s\n", "Failed to set network item \"lxc.net.0.link\""); + goto on_error_put; + } + + if (!c->set_config_item(c, "lxc.net.0.flags", "up")) { + lxc_error("%s\n", "Failed to set network item \"lxc.net.0.flags\""); + goto on_error_put; + } + + if (!c->set_config_item(c, "lxc.net.0.name", "eth0")) { + lxc_error("%s\n", "Failed to set network item \"lxc.net.0.name\""); + goto on_error_put; + } + + if (!c->createl(c, "busybox", NULL, NULL, 0, NULL)) { + lxc_error("%s\n", "Failed to create busybox container \"livepatch\""); + goto on_error_put; + } + + if (!c->is_defined(c)) { + lxc_error("%s\n", "Container \"livepatch\" is not defined"); + goto on_error_put; + } + + c->clear_config(c); + + if (!c->load_config(c, NULL)) { + lxc_error("%s\n", "Failed to load config for container \"livepatch\""); + goto on_error_stop; + } + + if (!c->want_daemonize(c, true)) { + lxc_error("%s\n", "Failed to mark container \"livepatch\" daemonized"); + goto on_error_stop; + } + + if (!c->startl(c, 0, NULL)) { + lxc_error("%s\n", "Failed to start container \"livepatch\" daemonized"); + goto on_error_stop; + } + + /* Test whether the current value is ok. */ + value = c->get_running_config_item(c, "lxc.net.0.name"); + if (!value) { + lxc_error("%s\n", "Failed to retrieve running config item \"lxc.net.0.name\""); + goto on_error_stop; + } + + if (strcmp(value, "eth0")) { + lxc_error("Retrieved unexpected value for config item " + "\"lxc.net.0.name\": eth0 != %s", value); + free(value); + goto on_error_stop; + } + free(value); + + /* Change current in-memory value. */ + if (!c->set_running_config_item(c, "lxc.net.0.name", "blabla")) { + lxc_error("%s\n", "Failed to set running config item " + "\"lxc.net.0.name\" to \"blabla\""); + goto on_error_stop; + } + + /* Verify change. */ + value = c->get_running_config_item(c, "lxc.net.0.name"); + if (!value) { + lxc_error("%s\n", "Failed to retrieve running config item \"lxc.net.0.name\""); + goto on_error_stop; + } + + if (strcmp(value, "blabla")) { + lxc_error("Retrieved unexpected value for config item " + "\"lxc.net.0.name\": blabla != %s", value); + free(value); + goto on_error_stop; + } + free(value); + + /* Change current in-memory value. */ + if (!c->set_running_config_item(c, "lxc.net.0.name", "eth0")) { + lxc_error("%s\n", "Failed to set running config item " + "\"lxc.net.0.name\" to \"eth0\""); + goto on_error_stop; + } + + /* Add new in-memory value. */ + if (!c->set_running_config_item(c, "lxc.net.1.type", "veth")) { + lxc_error("%s\n", "Failed to set running config item " + "\"lxc.net.1.type\" to \"veth\""); + goto on_error_stop; + } + + /* Verify change. */ + value = c->get_running_config_item(c, "lxc.net.1.type"); + if (!value) { + lxc_error("%s\n", "Failed to retrieve running config item \"lxc.net.1.type\""); + goto on_error_stop; + } + + if (strcmp(value, "veth")) { + lxc_error("Retrieved unexpected value for config item " + "\"lxc.net.1.type\": veth != %s", value); + free(value); + goto on_error_stop; + } + free(value); + + /* Add new in-memory value. */ + if (!c->set_running_config_item(c, "lxc.net.1.flags", "up")) { + lxc_error("%s\n", "Failed to set running config item " + "\"lxc.net.1.flags\" to \"up\""); + goto on_error_stop; + } + + /* Verify change. */ + value = c->get_running_config_item(c, "lxc.net.1.flags"); + if (!value) { + lxc_error("%s\n", "Failed to retrieve running config item \"lxc.net.1.flags\""); + goto on_error_stop; + } + + if (strcmp(value, "up")) { + lxc_error("Retrieved unexpected value for config item " + "\"lxc.net.1.flags\": up != %s", value); + free(value); + goto on_error_stop; + } + free(value); + + /* Add new in-memory value. */ + if (!c->set_running_config_item(c, "lxc.net.1.link", "lxcbr0")) { + lxc_error("%s\n", "Failed to set running config item " + "\"lxc.net.1.link\" to \"lxcbr0\""); + goto on_error_stop; + } + + /* Verify change. */ + value = c->get_running_config_item(c, "lxc.net.1.link"); + if (!value) { + lxc_error("%s\n", "Failed to retrieve running config item \"lxc.net.1.link\""); + goto on_error_stop; + } + + if (strcmp(value, "lxcbr0")) { + lxc_error("Retrieved unexpected value for config item " + "\"lxc.net.1.link\": lxcbr0 != %s", value); + free(value); + goto on_error_stop; + } + free(value); + + if (!c->reboot(c)) { + lxc_error("%s", "Failed to create container \"livepatch\""); + goto on_error_stop; + } + + /* Busybox shouldn't take long to reboot. Sleep for 5s. */ + sleep(5); + + if (!c->is_running(c)) { + lxc_error("%s\n", "Failed to reboot container \"livepatch\""); + goto on_error_destroy; + } + + /* Remove in-memory value. */ + if (!c->set_running_config_item(c, "lxc.net.1.name", "eth1")) { + lxc_error("%s\n", "Failed to clear running config item " + "\"lxc.net.1.name\""); + goto on_error_stop; + } + + if (!c->stop(c)) { + lxc_error("%s\n", "Failed to stop container \"livepatch\""); + goto on_error_stop; + } + + if (!c->startl(c, 0, NULL)) { + lxc_error("%s\n", "Failed to start container \"livepatch\" daemonized"); + goto on_error_destroy; + } + + /* Remove in-memory value. */ + if (!c->set_running_config_item(c, "lxc.net.1.mtu", "3000")) { + lxc_error("%s\n", "Failed to set running config item " + "\"lxc.net.1.mtu\""); + goto on_error_stop; + } + + ret = 0; + +on_error_stop: + if (c->is_running(c) && !c->stop(c)) + lxc_error("%s\n", "Failed to stop container \"livepatch\""); + +on_error_destroy: + if (!c->destroy(c)) + lxc_error("%s\n", "Failed to destroy container \"livepatch\""); + +on_error_put: + lxc_container_put(c); + exit(ret); +} -- 2.47.2