From b88f3ebb3341281fa7e61dc4f039062e72c86b9e Mon Sep 17 00:00:00 2001 From: Eric Fahlgren Date: Thu, 8 May 2025 15:28:52 -0700 Subject: [PATCH] imagebuilder: exclude metadata for profiles that have no kernel Device profiles that specify 'DEFAULT := n' are being included in the imagebuilder metadata, specifically in .profiles.mk, even though there is no kernel built for the device. This results in 'make info' showing the device as valid, but then 'make image PROFILE=xxx' failing with 'No rule to make target xxx-kernel.bin ...' We exclude these profiles from the imagebuilder, avoiding these errors. Fixes: https://github.com/openwrt/openwrt/issues/18410 Signed-off-by: Eric Fahlgren Link: https://github.com/openwrt/openwrt/pull/18748 Signed-off-by: Robert Marko --- scripts/target-metadata.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/target-metadata.pl b/scripts/target-metadata.pl index ce96d1e7d53..da42f04a24f 100755 --- a/scripts/target-metadata.pl +++ b/scripts/target-metadata.pl @@ -441,7 +441,7 @@ sub gen_profile_mk() { my @targets = parse_target_metadata($file); foreach my $cur (@targets) { next unless $cur->{id} eq $target; - my @profile_ids_unique = do { my %seen; grep { !$seen{$_}++} map { $_->{id} } @{$cur->{profiles}}}; + my @profile_ids_unique = do { my %seen; grep { !$seen{$_}++} map { $_->{id} } grep { $_->{default} !~ /^n/ } @{$cur->{profiles}}}; print "PROFILE_NAMES = ".join(" ", @profile_ids_unique)."\n"; foreach my $profile (@{$cur->{profiles}}) { print $profile->{id}.'_NAME:='.$profile->{name}."\n"; -- 2.47.2