From 5d34ac071d049d5b467fe472d7ddf1be6bd6bf9f Mon Sep 17 00:00:00 2001 From: Andreas Herz Date: Fri, 4 Mar 2016 22:29:02 +0100 Subject: [PATCH] rule-parsing: remove unnecessary code Those lines were included former to prevent possible null pointer dereference but that won't happen anymore with the rest of the rework done in the code. The code even results in a control flow issue reported by coverity scan, so just remove it. --- src/detect-msg.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/detect-msg.c b/src/detect-msg.c index eddf311972..5a5f4c5dfd 100644 --- a/src/detect-msg.c +++ b/src/detect-msg.c @@ -75,10 +75,6 @@ static int DetectMsgSetup (DetectEngineCtx *de_ctx, Signature *s, char *msgstr) goto error; } - /* make sure that we don't proceed with null pointer */ - if (unlikely(str == NULL)) - goto error; - len = strlen(str); if (len == 0) goto error; -- 2.47.2