From 2cfe4fc6b7f09f896857ef7f5661c9fe190709b1 Mon Sep 17 00:00:00 2001 From: Shivani Bhardwaj Date: Mon, 7 Oct 2019 16:08:18 +0530 Subject: [PATCH] Check data directory's permission while updating sources Closes redmine ticket #3219. --- suricata/update/commands/updatesources.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/suricata/update/commands/updatesources.py b/suricata/update/commands/updatesources.py index a47c24c..06a0d11 100644 --- a/suricata/update/commands/updatesources.py +++ b/suricata/update/commands/updatesources.py @@ -71,8 +71,12 @@ def compare_sources(initial_content, final_content): def write_and_compare(initial_content, fileobj): - with open(local_index_filename, "wb") as outobj: - outobj.write(fileobj.getvalue()) + try: + with open(local_index_filename, "wb") as outobj: + outobj.write(fileobj.getvalue()) + except IOError as ioe: + logger.error("Failed to open directory: %s", ioe) + return 1 with open(local_index_filename, "rb") as stream: final_content = yaml.safe_load(stream) compare_sources(initial_content, final_content) -- 2.47.3