From d8347039cf2348d66eee0477a263e3efdafdf03d Mon Sep 17 00:00:00 2001 From: etimberg Date: Tue, 29 Mar 2016 20:10:29 -0400 Subject: [PATCH] Better handling when data.datasets does not exist --- src/core/core.controller.js | 12 +++++++----- src/core/core.legend.js | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/core/core.controller.js b/src/core/core.controller.js index 63bfe522f..fb635453f 100644 --- a/src/core/core.controller.js +++ b/src/core/core.controller.js @@ -347,11 +347,13 @@ module.exports = function(Chart) { var elementsArray = []; var found = (function() { - for (var i = 0; i < this.data.datasets.length; i++) { - if (helpers.isDatasetVisible(this.data.datasets[i])) { - for (var j = 0; j < this.data.datasets[i].metaData.length; j++) { - if (this.data.datasets[i].metaData[j].inRange(eventPosition.x, eventPosition.y)) { - return this.data.datasets[i].metaData[j]; + if (this.data.datasets) { + for (var i = 0; i < this.data.datasets.length; i++) { + if (helpers.isDatasetVisible(this.data.datasets[i])) { + for (var j = 0; j < this.data.datasets[i].metaData.length; j++) { + if (this.data.datasets[i].metaData[j].inRange(eventPosition.x, eventPosition.y)) { + return this.data.datasets[i].metaData[j]; + } } } } diff --git a/src/core/core.legend.js b/src/core/core.legend.js index 0f7468809..4c0ea4876 100644 --- a/src/core/core.legend.js +++ b/src/core/core.legend.js @@ -35,7 +35,7 @@ module.exports = function(Chart) { // lineJoin : // lineWidth : generateLabels: function(data) { - return data.datasets.map(function(dataset, i) { + return helpers.isArray(data.datasets) ? data.datasets.map(function(dataset, i) { return { text: dataset.label, fillStyle: dataset.backgroundColor, @@ -50,7 +50,7 @@ module.exports = function(Chart) { // Below is extra data used for toggling the datasets datasetIndex: i }; - }, this); + }, this) : []; } } }; -- 2.47.2