From 5c6d218e385755766ff427b3e707510f0ce175c5 Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Tue, 19 May 2015 10:38:51 -0400 Subject: [PATCH] Fix bindresvport_sa port byte swap bug The sa_setport() helper handles conversion to network byte order, so bindresvport_sa() should not itself call htons() on the port argument. (This bug was introduced in commit 0d04b60d159ab83b943e43802b1449a3b074bc83 when adding bindresvport_sa(). It was my fault, not Andreas Schneider's.) ticket: 8197 (new) target_version: 1.13.3 tags: pullup --- src/lib/rpc/bindresvport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/rpc/bindresvport.c b/src/lib/rpc/bindresvport.c index ccc4d73c6b..a421dd8ec7 100644 --- a/src/lib/rpc/bindresvport.c +++ b/src/lib/rpc/bindresvport.c @@ -76,7 +76,7 @@ bindresvport_sa(int sd, struct sockaddr *sa) res = -1; errno = EADDRINUSE; for (i = 0; i < NPORTS && res < 0 && errno == EADDRINUSE; i++) { - sa_setport(sa, htons(port++)); + sa_setport(sa, port++); if (port > ENDPORT) { port = STARTPORT; } -- 2.47.2