From e31ee9853305ba840d2b51acc6a19d3fe9be4f79 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Wed, 20 Feb 2019 18:38:07 +0100 Subject: [PATCH] autotools: handle getgrgid_r on bionic Signed-off-by: Christian Brauner --- configure.ac | 6 +----- src/lxc/Makefile.am | 10 ++-------- src/lxc/conf.c | 4 ++++ 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/configure.ac b/configure.ac index 4fc393235..dadc29aaf 100644 --- a/configure.ac +++ b/configure.ac @@ -665,11 +665,7 @@ AC_CHECK_LIB(pthread, main) AC_CHECK_FUNCS(pthread_atfork) AC_CHECK_FUNCS(statvfs) AC_CHECK_LIB(util, openpty) -AC_CHECK_FUNCS([openpty hasmntopt setmntent endmntent utmpxname]) -AC_CHECK_FUNCS([getgrgid_r], - AM_CONDITIONAL(HAVE_GETGRGID_R, true) - AC_DEFINE(HAVE_GETGRGID_R,1,[Have getgrgid_r]), - AM_CONDITIONAL(HAVE_GETGRGID_R, false)) +AC_CHECK_FUNCS([getgrgid_r openpty hasmntopt setmntent endmntent utmpxname]) AC_CHECK_FUNCS([getline], AM_CONDITIONAL(HAVE_GETLINE, true) AC_DEFINE(HAVE_GETLINE,1,[Have getline]), diff --git a/src/lxc/Makefile.am b/src/lxc/Makefile.am index d86d2e58f..fe6c0b7da 100644 --- a/src/lxc/Makefile.am +++ b/src/lxc/Makefile.am @@ -44,6 +44,7 @@ noinst_HEADERS = \ if IS_BIONIC noinst_HEADERS += \ ../include/fexecve.h \ + ../include/getgrgid_r.h \ ../include/ifaddrs.h \ ../include/openpty.h \ ../include/lxcmntent.h @@ -59,10 +60,6 @@ if !HAVE_GETSUBOPT noinst_HEADERS += ../include/getsubopt.h endif -if !HAVE_GETGRGID_R -noinst_HEADERS += ../include/getgrgid_r.h -endif - sodir=$(libdir) LSM_SOURCES = \ @@ -142,6 +139,7 @@ endif if IS_BIONIC liblxc_la_SOURCES += \ ../include/fexecve.c ../include/fexecve.h \ + ../include/getgrgid_r.c ../include/getgrgid_r.h \ ../include/ifaddrs.c ../include/ifaddrs.h \ ../include/openpty.c ../include/openpty.h \ ../include/lxcmntent.c ../include/lxcmntent.h @@ -326,10 +324,6 @@ if !HAVE_STRLCAT init_lxc_static_SOURCES += ../include/strlcat.c ../include/strlcat.h endif -if !HAVE_GETGRGID_R -liblxc_la_SOURCES += ../include/getgrgid_r.c ../include/getgrgid_r.h -endif - init_lxc_static_LDFLAGS = -all-static init_lxc_static_LDADD = @CAP_LIBS@ init_lxc_static_CFLAGS = $(AM_CFLAGS) -DNO_LXC_CONF diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 5d8090703..f1414611f 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -88,6 +88,10 @@ #include "utils.h" #include "lsm/lsm.h" +#if !HAVE_GETGRGID_R +#include "../include/getgrgid_r.h" +#endif + #if HAVE_LIBCAP #include #endif -- 2.47.2