From 41a604025ad1ea23c556baa3943b6b6db4108d9e Mon Sep 17 00:00:00 2001 From: Ben Darnell Date: Sat, 20 Jun 2020 12:52:44 -0400 Subject: [PATCH] test: Use default timeouts in sigchild test The 1s timeout used here has become flaky with the introduction of a sleep (before the timeout even starts). --- tornado/test/process_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tornado/test/process_test.py b/tornado/test/process_test.py index 1f2992024..2178b34f7 100644 --- a/tornado/test/process_test.py +++ b/tornado/test/process_test.py @@ -235,7 +235,7 @@ class SubprocessTest(AsyncTestCase): os.kill(subproc.pid, signal.SIGTERM) try: - ret = self.wait(timeout=1.0) + ret = self.wait() except AssertionError: # We failed to get the termination signal. This test is # occasionally flaky on pypy, so try to get a little more @@ -246,7 +246,7 @@ class SubprocessTest(AsyncTestCase): fut = subproc.stdout.read_until_close() fut.add_done_callback(lambda f: self.stop()) # type: ignore try: - self.wait(timeout=1.0) + self.wait() except AssertionError: raise AssertionError("subprocess failed to terminate") else: -- 2.47.2