From 21231fd1980fbae41bba3540be0e5cea6db60868 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Sat, 30 Sep 2017 16:50:47 +0200 Subject: [PATCH] github: codeowners syntax fixes --- .github/CODEOWNERS | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7e71bc8ce1..8a2e4b4e29 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,21 +1,15 @@ # https://help.github.com/articles/about-codeowners/ # # last match wins, so put more specific matches towards the end +# +# only ppl with push rights in the repo can be owners +# https://github.com/isaacs/github/issues/989#issuecomment-320475904 +# +# additionally, it seems only the directoy syntax works. +# e.g. '/src/source-*.[ch] @regit' seems to have no effect. * @OISF/core-team -rust/* @victorjulien @jasonish -src/source-* @regit -doc/* @norg -src/detect-engine* @victorjulien -*ssl* @thus @OISF/core-team -*tls* @thus @OISF/core-team -*nfs* @victorjulien -*dns* @jasonish -*ntp* @chifflier - -*prelude* @ToToL - -*napatech* @psanders240 - -.github/ @victorjulien +/doc/ @norg +/rust/ @victorjulien @jasonish +/.github/ @victorjulien -- 2.47.2