From 95481a91760eda26510ee0e60348d3acdfe37629 Mon Sep 17 00:00:00 2001 From: Jason Ish Date: Wed, 9 May 2018 06:50:03 -0600 Subject: [PATCH] eve/json/xff - remove check for flow being NULL. Fix Coverity issue: ** CID 1435535: Null pointer dereferences (REVERSE_INULL) /src/output-json-file.c: 212 in JsonBuildFileInfoRecord() Where we check a variable for being NULL, when all paths to the code show that it can't be NULL. --- src/output-json-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/output-json-file.c b/src/output-json-file.c index 56d3f56589..29e70a7b55 100644 --- a/src/output-json-file.c +++ b/src/output-json-file.c @@ -209,7 +209,7 @@ json_t *JsonBuildFileInfoRecord(const Packet *p, const File *ff, json_object_set_new(fjs, "tx_id", json_integer(ff->txid)); /* xff header */ - if ((xff_cfg != NULL) && !(xff_cfg->flags & XFF_DISABLED) && p->flow != NULL) { + if ((xff_cfg != NULL) && !(xff_cfg->flags & XFF_DISABLED)) { int have_xff_ip = 0; char buffer[XFF_MAXLEN]; -- 2.47.2