From 0212dc6f33159d55a41ab6ed20c0b37ebb14c66e Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Wed, 15 Apr 2020 14:09:11 +0200 Subject: [PATCH] rexec: free argv array on failure Fixes: Coverity 1461736. Signed-off-by: Christian Brauner --- src/lxc/rexec.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/lxc/rexec.c b/src/lxc/rexec.c index 3bb43a215..cd76efb3c 100644 --- a/src/lxc/rexec.c +++ b/src/lxc/rexec.c @@ -169,13 +169,12 @@ extern char **environ; int lxc_rexec(const char *memfd_name) { + __do_free_string_list char **argv = NULL; int ret; - char **argv = NULL; ret = is_memfd(); if (ret < 0 && ret == -ENOTRECOVERABLE) { - fprintf(stderr, - "%s - Failed to determine whether this is a memfd\n", + fprintf(stderr, "%s - Failed to determine whether this is a memfd\n", strerror(errno)); return -1; } else if (ret > 0) { @@ -184,8 +183,7 @@ int lxc_rexec(const char *memfd_name) ret = parse_argv(&argv); if (ret < 0) { - fprintf(stderr, - "%s - Failed to parse command line parameters\n", + fprintf(stderr, "%s - Failed to parse command line parameters\n", strerror(errno)); return -1; } -- 2.47.2