From af25cae409b423ee779eef0ac388fa6758ea5f97 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Mon, 4 May 2020 15:50:41 +0200 Subject: [PATCH] terminal: remove unneeded if condition Fixes: Coverity 1461742. Signed-off-by: Christian Brauner --- src/lxc/terminal.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/lxc/terminal.c b/src/lxc/terminal.c index c2516b205..c883b1c8c 100644 --- a/src/lxc/terminal.c +++ b/src/lxc/terminal.c @@ -1167,10 +1167,7 @@ int lxc_terminal_map_ids(struct lxc_conf *c, struct lxc_terminal *terminal) if (strcmp(terminal->name, "") == 0) return 0; - if (terminal->slave >= 0) - ret = userns_exec_mapped_root(terminal->name, terminal->slave, c); - else - ret = userns_exec_mapped_root(terminal->name, terminal->slave, c); + ret = userns_exec_mapped_root(terminal->name, terminal->slave, c); if (ret < 0) { return log_error(-1, "Failed to chown terminal %d(%s)", terminal->slave, terminal->name); -- 2.47.2