From 2744c1f110917d4ea61ab9bd2c4b364fdd8db8af Mon Sep 17 00:00:00 2001 From: Ben Darnell Date: Wed, 10 Dec 2025 22:10:20 -0500 Subject: [PATCH] tox: Pin pycares version 4 due to backwards-incompatible changes --- docs/caresresolver.rst | 3 +++ tox.ini | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/caresresolver.rst b/docs/caresresolver.rst index 4e0058eac..57caa7d19 100644 --- a/docs/caresresolver.rst +++ b/docs/caresresolver.rst @@ -19,6 +19,9 @@ wrapper ``pycares``). the default for ``tornado.simple_httpclient``, but other libraries may default to ``AF_UNSPEC``. + This class requires ``pycares`` version 4. Since this class is deprecated, it will not be + updated to support ``pycares`` version 5. + .. deprecated:: 6.2 This class is deprecated and will be removed in Tornado 7.0. Use the default thread-based resolver instead. diff --git a/tox.ini b/tox.ini index 88e8eb9df..db0a4b604 100644 --- a/tox.ini +++ b/tox.ini @@ -46,7 +46,10 @@ basepython = deps = full: pycurl full: twisted - full: pycares + # Pycares 5 has some backwards-incompatible changes that we don't support. + # And since CaresResolver is deprecated, I do not expect to fix it, so just + # pin the previous version. (This should really be in requirements.{in,txt} instead) + full: pycares<5 docs: -r{toxinidir}/requirements.txt lint: -r{toxinidir}/requirements.txt -- 2.47.3