From d10d5a050866dd70942201b55df59407017b7fd0 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 26 Feb 2025 09:12:39 +0100 Subject: [PATCH] tpm2-setup: remove redundant fflush_and_check() The immediately following flink_tmpfile() does that anyway, hence no need to do so explicitly beforehand. (Also the log message was wrong: it says "sync" but here we "flush", which is a much weaker operation) --- src/tpm2-setup/tpm2-setup.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/tpm2-setup/tpm2-setup.c b/src/tpm2-setup/tpm2-setup.c index 43771a28ca2..6a9a7852e29 100644 --- a/src/tpm2-setup/tpm2-setup.c +++ b/src/tpm2-setup/tpm2-setup.c @@ -348,10 +348,6 @@ static int run(int argc, char *argv[]) { if (fchmod(fileno(f), 0444) < 0) return log_error_errno(errno, "Failed to adjust access mode of SRK public key file '%s' to 0444: %m", pem_path); - r = fflush_and_check(f); - if (r < 0) - return log_error_errno(r, "Failed to sync SRK key to disk: %m"); - r = flink_tmpfile(f, t, pem_path, LINK_TMPFILE_SYNC|LINK_TMPFILE_REPLACE); if (r < 0) return log_error_errno(r, "Failed to move SRK public key file to '%s': %m", pem_path); @@ -382,10 +378,6 @@ static int run(int argc, char *argv[]) { if (fchmod(fileno(f), 0444) < 0) return log_error_errno(errno, "Failed to adjust access mode of SRK public key file '%s' to 0444: %m", tpm2b_public_path); - r = fflush_and_check(f); - if (r < 0) - return log_error_errno(r, "Failed to sync SRK key to disk: %m"); - r = flink_tmpfile(f, t, tpm2b_public_path, LINK_TMPFILE_SYNC|LINK_TMPFILE_REPLACE); if (r < 0) return log_error_errno(r, "Failed to move SRK public key file to '%s': %m", tpm2b_public_path); -- 2.47.3