From 44296e41db20b40d0b9a4cbe320d262ffdd8905d Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Sat, 11 Apr 2026 22:52:47 +0100 Subject: [PATCH] test-json: add iszero_safe guards for float division at index 0 and 1 The existing iszero_safe guards at index 9 and 10 were added to silence Coverity, but the same division-by-float-zero warning also applies to the divisions at index 0 (DBL_MIN) and 1 (DBL_MAX). CID#1587762 Follow-up for 7f133c996c8b1ea9219540ec8f966b64b58d30a6 --- src/test/test-json.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/test-json.c b/src/test/test-json.c index 8e2c8621c1f..1bd5d94f987 100644 --- a/src/test/test-json.c +++ b/src/test/test-json.c @@ -690,7 +690,9 @@ static void test_float_match(sd_json_variant *v) { assert_se(sd_json_variant_is_array(v)); assert_se(sd_json_variant_elements(v) == 11); + assert_se(!iszero_safe(sd_json_variant_real(sd_json_variant_by_index(v, 0)))); assert_se(fabs(1.0 - (DBL_MIN / sd_json_variant_real(sd_json_variant_by_index(v, 0)))) <= delta); + assert_se(!iszero_safe(sd_json_variant_real(sd_json_variant_by_index(v, 1)))); assert_se(fabs(1.0 - (DBL_MAX / sd_json_variant_real(sd_json_variant_by_index(v, 1)))) <= delta); assert_se(sd_json_variant_is_null(sd_json_variant_by_index(v, 2))); /* nan is not supported by json → null */ assert_se(sd_json_variant_is_null(sd_json_variant_by_index(v, 3))); /* +inf is not supported by json → null */ -- 2.47.3