From 304fe67b06c1f010a164806a12b68cfce9bd0d2b Mon Sep 17 00:00:00 2001 From: j00356287 Date: Thu, 5 Sep 2019 23:39:15 +0800 Subject: [PATCH] Improve testcase condition statement for dialects We could get dialect.requires_name_normalize rather than use hard code as "firebird" or "oracle", since we have add `normalize` attribute for quite a long time. --- test/engine/test_reflection.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/engine/test_reflection.py b/test/engine/test_reflection.py index 2451822b1c..2bff3fa627 100644 --- a/test/engine/test_reflection.py +++ b/test/engine/test_reflection.py @@ -1146,10 +1146,7 @@ class ReflectionTest(fixtures.TestBase, ComparesTables): ) sa.Index("where", table_a.c["from"]) - # There's currently no way to calculate identifier case - # normalization in isolation, so... - - if testing.against("firebird", "oracle"): + if meta.bind.dialect.requires_name_normalize: check_col = "TRUE" else: check_col = "true" -- 2.47.3