From 0b362e3a4d3061ee1acdcaf3aa32f4c6f74dcbbe Mon Sep 17 00:00:00 2001 From: Shchelkunov Artem Date: Fri, 20 Aug 2021 19:45:54 +0500 Subject: [PATCH] Fix: buffer overflow bug Found by static analyzer svace Static analyzer message: Array 'token' of size 65536 bytes passed to function 'rrinternal_parse_rdata' at str2wire.c:679 by passing as 2nd parameter to function 'rrinternal_parse_rdata' at str2wire.c:775, where it is accessed by unacceptable index. This may lead to buffer overflow. on-behalf-of: @ideco-team --- sldns/str2wire.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sldns/str2wire.c b/sldns/str2wire.c index 293abf79a..8c6664cde 100644 --- a/sldns/str2wire.c +++ b/sldns/str2wire.c @@ -601,7 +601,7 @@ sldns_affix_token(sldns_buffer* strbuf, char* token, size_t* token_len, size_t addstrlen = 0; /* add space */ - if(addlen < 1) return 0; + if(addlen < 2) return 0; token[*token_strlen] = ' '; token[++(*token_strlen)] = 0; -- 2.47.2