From 993c7c313366f3bcb86b695d6d3b0355fbc53d3f Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Tue, 4 Oct 2016 12:36:30 -0400 Subject: [PATCH] Error on discarded qualifiers in gcc If a function call passes a const pointer to a function accepting the same pointer type without the const qualifier, that should be treated as an erorr if possible. In sufficiently recent gcc, pass -Werror=discarded-qualifiers. (In clang, this is already covered by -Werror=incompatible-pointer-types which we recently added.) --- src/aclocal.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/aclocal.m4 b/src/aclocal.m4 index b9f9d2af1b..bd2eb48d96 100644 --- a/src/aclocal.m4 +++ b/src/aclocal.m4 @@ -526,7 +526,7 @@ if test "$GCC" = yes ; then TRY_WARN_CC_FLAG(-Wno-format-zero-length) # Other flags here may not be supported on some versions of # gcc that people want to use. - for flag in overflow strict-overflow missing-format-attribute missing-prototypes return-type missing-braces parentheses switch unused-function unused-label unused-variable unused-value unknown-pragmas sign-compare newline-eof error=uninitialized error=pointer-arith error=int-conversion error=incompatible-pointer-types ; do + for flag in overflow strict-overflow missing-format-attribute missing-prototypes return-type missing-braces parentheses switch unused-function unused-label unused-variable unused-value unknown-pragmas sign-compare newline-eof error=uninitialized error=pointer-arith error=int-conversion error=incompatible-pointer-types error=discarded-qualifiers ; do TRY_WARN_CC_FLAG(-W$flag) done # old-style-definition? generates many, many warnings -- 2.47.2