From 201e8c815709f306db8227c1054e99888d135c6f Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Thu, 9 Mar 2017 02:00:35 +0000 Subject: [PATCH] programs/Makefile: remove zstd-internal target zstd-internal was intended to be a helper target, but it doesn't help at all, what it does in practice is a useless rebuild of zstd every time "make zstd" is invoked. Fixes: 030ac243a0f3 ("Changed Makefile to generate zstd with .gz support by default") --- programs/Makefile | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/programs/Makefile b/programs/Makefile index 5620a25a3..a935c744a 100644 --- a/programs/Makefile +++ b/programs/Makefile @@ -83,8 +83,11 @@ all: zstd $(ZSTDDECOMP_O): CFLAGS += $(ALIGN_LOOP) -zstd-internal : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) -zstd-internal : $(ZSTDLIB_OBJ) zstdcli.o fileio.o bench.o datagen.o dibio.o +zstd : CPPFLAGS += $(ZLIBCPP) +zstd : LDFLAGS += $(ZLIBLD) +zstd-nogz : HAVE_ZLIB=0 +zstd zstd-nogz : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) +zstd zstd-nogz : $(ZSTDLIB_OBJ) zstdcli.o fileio.o bench.o datagen.o dibio.o ifeq ($(HAVE_ZLIB), 1) @echo "==> building zstd with .gz decompression support " else @@ -95,13 +98,6 @@ ifneq (,$(filter Windows%,$(OS))) endif $(CC) $(FLAGS) $^ $(RES_FILE) -o zstd$(EXT) $(LDFLAGS) -zstd-nogz : HAVE_ZLIB=0 -zstd-nogz : zstd-internal - -zstd : CPPFLAGS += $(ZLIBCPP) -zstd : LDFLAGS += $(ZLIBLD) -zstd : zstd-internal - zstd-release: DEBUGFLAGS := zstd-release: zstd -- 2.47.2