From b770fd2981a26e8eb0ab01ace0a6755548155102 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Mon, 9 Dec 2013 23:21:20 +0100 Subject: [PATCH] http header: improve realloc failure checking. Bug #1062. --- src/detect-engine-hhd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/detect-engine-hhd.c b/src/detect-engine-hhd.c index 8bdc6acedb..759c826a02 100644 --- a/src/detect-engine-hhd.c +++ b/src/detect-engine-hhd.c @@ -156,12 +156,15 @@ static uint8_t *DetectEngineHHDGetBufferForTX(htp_tx_t *tx, uint64_t tx_id, } /* the extra 4 bytes if for ": " and "\r\n" */ - headers_buffer = SCRealloc(headers_buffer, headers_buffer_len + size1 + size2 + 4); - if (unlikely(headers_buffer == NULL)) { + uint8_t *new_headers_buffer = SCRealloc(headers_buffer, headers_buffer_len + size1 + size2 + 4); + if (unlikely(new_headers_buffer == NULL)) { + if (headers_buffer != NULL) + SCFree(headers_buffer); det_ctx->hhd_buffers[index] = NULL; det_ctx->hhd_buffers_len[index] = 0; goto end; } + headers_buffer = new_headers_buffer; memcpy(headers_buffer + headers_buffer_len, bstr_ptr(h->name), size1); headers_buffer_len += size1; -- 2.47.2