From 364c608911af2f227695bb527d4e42f091ee8bd3 Mon Sep 17 00:00:00 2001 From: Nehal J Wani Date: Sun, 28 Jan 2018 03:02:57 -0500 Subject: [PATCH] Always set appdefault_get() output argument gcc 7 cannot determine that appdefault_get() always sets *ret_value when it returns zero, so issues a "may be used uninitialized" warning in its caller. Set *ret_value at the beginning of the function body in accordance with current practices. [ghudson@mit.edu: clarified commit message] ticket: 8639 (new) tags: pullup target_version: 1.16-next target_version: 1.15-next --- src/lib/krb5/krb/appdefault.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/krb5/krb/appdefault.c b/src/lib/krb5/krb/appdefault.c index 73fd2605e8..3f7dc2377f 100644 --- a/src/lib/krb5/krb/appdefault.c +++ b/src/lib/krb5/krb/appdefault.c @@ -44,6 +44,8 @@ appdefault_get(krb5_context context, const char *appname, const krb5_data *realm krb5_error_code retval; const char * realmstr = realm?realm->data:NULL; + *ret_value = NULL; + if (!context || (context->magic != KV5M_CONTEXT)) return KV5M_CONTEXT; -- 2.47.2