From 6d822841648761ac888b9a95693ad87a8aaf165c Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Tue, 19 Jun 2018 13:03:05 -0400 Subject: [PATCH] Fix minor leak in kdb5_util purge_mkeys In kdb5_purge_mkeys(), if krb5_dbe_update_mkey_aux() fails, use the cleanup label to free any allocated memory instead of returning immediately. Reported by Bean Zhang. ticket: 8702 --- src/kadmin/dbutil/kdb5_mkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kadmin/dbutil/kdb5_mkey.c b/src/kadmin/dbutil/kdb5_mkey.c index 2efe3176e8..5395a6070c 100644 --- a/src/kadmin/dbutil/kdb5_mkey.c +++ b/src/kadmin/dbutil/kdb5_mkey.c @@ -1297,7 +1297,7 @@ kdb5_purge_mkeys(int argc, char *argv[]) com_err(progname, retval, _("while updating mkey_aux data for master principal entry")); exit_status++; - return; + goto cleanup_return; } if ((retval = krb5_timeofday(util_context, &now))) { -- 2.47.2