From 6232d57a5a94db0a5b76acf565bb68bd8c4ddc12 Mon Sep 17 00:00:00 2001
From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Wed, 23 Oct 2019 10:50:33 +0200
Subject: [PATCH] Basic validation of $GENERATE parameters

(cherry picked from commit 775a673a1798d01e5e259a00cff7a757f5350f40)
---
 pdns/zoneparser-tng.cc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/pdns/zoneparser-tng.cc b/pdns/zoneparser-tng.cc
index 49841c4b73..c98fdd2463 100644
--- a/pdns/zoneparser-tng.cc
+++ b/pdns/zoneparser-tng.cc
@@ -313,6 +313,10 @@ bool ZoneParserTNG::get(DNSResourceRecord& rr, std::string* comment)
       d_templatestep=1;
       d_templatestop=0;
       sscanf(range.c_str(),"%u-%u/%u", &d_templatecounter, &d_templatestop, &d_templatestep);
+      if (d_templatestep < 1 ||
+          d_templatestop < d_templatecounter) {
+        throw exception("Illegal $GENERATE parameters");
+      }
       d_templateline=d_line;
       parts.pop_front();
       parts.pop_front();
-- 
2.47.2