From d9719c9f4112c3d1881cdbd09c484312f70e16a7 Mon Sep 17 00:00:00 2001 From: Greg Hudson Date: Tue, 19 Mar 2019 12:22:33 -0400 Subject: [PATCH] Fix memory leak in test KDB module test_get_s4u_x509_principal() needs to free canon before exiting. --- src/plugins/kdb/test/kdb_test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/kdb/test/kdb_test.c b/src/plugins/kdb/test/kdb_test.c index 8118e66406..690c025d8f 100644 --- a/src/plugins/kdb/test/kdb_test.c +++ b/src/plugins/kdb/test/kdb_test.c @@ -463,6 +463,7 @@ test_get_s4u_x509_principal(krb5_context context, const krb5_data *client_cert, krb5_principal_compare(context, princ, (*entry)->princ)) return 0; + match = FALSE; check(krb5_unparse_name_flags(context, princ, KRB5_PRINCIPAL_UNPARSE_NO_REALM, &princ_name)); @@ -474,11 +475,10 @@ test_get_s4u_x509_principal(krb5_context context, const krb5_data *client_cert, check(krb5_parse_name(context, canon, &canon_princ)); match = krb5_principal_compare(context, canon_princ, (*entry)->princ); krb5_free_principal(context, canon_princ); - if (match) - return 0; } - return KRB5KDC_ERR_CLIENT_NAME_MISMATCH; + free(canon); + return match ? 0 : KRB5KDC_ERR_CLIENT_NAME_MISMATCH; } static krb5_error_code -- 2.47.2