From fcc30c00ef955763655576f933d7d19cd4a6d2f9 Mon Sep 17 00:00:00 2001
From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 9 Jun 2020 17:19:09 +0200
Subject: [PATCH] rec: Don't copy the records when scanning for CNAME loops

---
 pdns/syncres.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index 71d4e39bd0..0aaa46abe3 100644
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -1168,7 +1168,7 @@ void SyncRes::updateValidationStatusInCache(const DNSName &qname, const QType& q
 
 static bool scanForCNAMELoop(const DNSName& name, const vector<DNSRecord>& records)
 {
-  for (const auto record: records) {
+  for (const auto& record: records) {
     if (record.d_type == QType::CNAME && record.d_place == DNSResourceRecord::ANSWER) {
       if (name == record.d_name) {
         return true;
-- 
2.47.2