From 899eff438e47c7beb723742fa25257a8be14f952 Mon Sep 17 00:00:00 2001 From: Milos Sakovic Date: Tue, 1 Nov 2016 17:36:51 +0100 Subject: [PATCH] Rename _detachEvents method to better describe it's behaviour. --- js/foundation.orbit.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/js/foundation.orbit.js b/js/foundation.orbit.js index 2ca922dde..c07e5f03a 100644 --- a/js/foundation.orbit.js +++ b/js/foundation.orbit.js @@ -43,7 +43,8 @@ class Orbit { * @private */ _init() { - this._detachEvents(); + // @TODO: consider discussion on PR #9278 about DOM pollution by changeSlide + this._reset(); this.$wrapper = this.$element.find(`.${this.options.containerClass}`); this.$slides = this.$element.find(`.${this.options.slideClass}`); @@ -241,9 +242,9 @@ class Orbit { } /** - * Detaches event listeners + * Resets Orbit so it can be reinitialized */ - _detachEvents() { + _reset() { // Don't do anything if there are no slides (first run) if (typeof this.$slides == 'undefined') { return; -- 2.47.2