From 3a65a8c1e0e25e0fb26601f8cb163a6865d5c377 Mon Sep 17 00:00:00 2001 From: David Reese Date: Wed, 26 Oct 2016 08:31:51 -0400 Subject: [PATCH] Reveal modal: Fix confusing AJAX example The .done() callback receives the data from the $.ajax request; if the request format is HTML, that `resp` will just be a string, not an object. So `resp.html` returns undefined and is non-sensical. This only makes sense if the request format is JSON. Since my impression is most people are going to be hitting a URL that returns HTML, I'd suggest just changing the example to `$modal.html(resp)` as I've done in this pull request. If you expect most people to be making a request that returns JSON, I would at least imply that in the URL, eg `$.ajax('/api/url.json')`. --- docs/pages/reveal.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/pages/reveal.md b/docs/pages/reveal.md index 68572f489..a1a6f0365 100644 --- a/docs/pages/reveal.md +++ b/docs/pages/reveal.md @@ -183,7 +183,7 @@ var $modal = $('#modal'); $.ajax('/url') .done(function(resp){ - $modal.html(resp.html).foundation('open'); + $modal.html(resp).foundation('open'); }); ``` -- 2.47.2