From a1cdb81201109d26d80156babfbb2f7ba8c02669 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Wed, 24 Dec 2025 09:55:03 +0000 Subject: [PATCH] Update comments to reflect changes in 8e0d32a4a1. Commit 8e0d32a4a1 fixed an issue by allowing the replication origin to be created while marking the table sync state as SUBREL_STATE_DATASYNC. Update the comment in check_old_cluster_subscription_state() to accurately describe this corrected behavior. Author: Amit Kapila Reviewed-by: Michael Paquier Backpatch-through: 17, where the code was introduced Discussion: https://postgr.es/m/CAA4eK1+KaSf5nV_tWy+SDGV6MnFnKMhdt41jJjSDWm6yCyOcTw@mail.gmail.com Discussion: https://postgr.es/m/aUTekQTg4OYnw-Co@paquier.xyz --- src/bin/pg_upgrade/check.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c index b4b596872a6..084415feadc 100644 --- a/src/bin/pg_upgrade/check.c +++ b/src/bin/pg_upgrade/check.c @@ -2055,9 +2055,9 @@ check_old_cluster_subscription_state(void) * other states listed below are not supported: * * a) SUBREL_STATE_DATASYNC: A relation upgraded while in this state - * would retain a replication slot, which could not be dropped by the - * sync worker spawned after the upgrade because the subscription ID - * used for the slot name won't match anymore. + * would retain a replication slot and origin. The sync worker spawned + * after the upgrade cannot be drop then because the subscription ID + * used for the slot and origin name no longer matches. * * b) SUBREL_STATE_SYNCDONE: A relation upgraded while in this state * would retain the replication origin when there is a failure in -- 2.47.3