From 25b7f6b9344a4bac18c26ce143a156ac2bcb3ec4 Mon Sep 17 00:00:00 2001 From: Radoslav Kolev Date: Fri, 19 Dec 2025 16:25:03 +0200 Subject: [PATCH] blsuki: Error out if unexpected arguments are supplied This can be especially helpful, as the Fedora version of the blscfg actually made use of positional arguments, but current implementation switched to parameters. For example what used to be "blscfg (hd0,gpt2)/..." now should be "blscfg --path (hd0,gpt2)/...)". In case of old configs/scripts still supplying positional arguments we will now error out instead of just ignoring them and falling back to defaults silently. Signed-off-by: Radoslav Kolev Reviewed-by: Daniel Kiper --- grub-core/commands/blsuki.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/grub-core/commands/blsuki.c b/grub-core/commands/blsuki.c index bfc4ef6d8..4133d3111 100644 --- a/grub-core/commands/blsuki.c +++ b/grub-core/commands/blsuki.c @@ -1458,9 +1458,11 @@ blsuki_cmd (grub_extcmd_context_t ctxt, enum blsuki_cmd_type cmd_type) } static grub_err_t -grub_cmd_blscfg (grub_extcmd_context_t ctxt, int argc __attribute__ ((unused)), +grub_cmd_blscfg (grub_extcmd_context_t ctxt, int argc, char **args __attribute__ ((unused))) { + if (argc != 0) + return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("unexpected argument(s) found, see --help")); return blsuki_cmd (ctxt, BLSUKI_BLS_CMD); } @@ -1468,9 +1470,11 @@ static grub_extcmd_t bls_cmd; #ifdef GRUB_MACHINE_EFI static grub_err_t -grub_cmd_uki (grub_extcmd_context_t ctxt, int argc __attribute__ ((unused)), +grub_cmd_uki (grub_extcmd_context_t ctxt, int argc, char **args __attribute__ ((unused))) { + if (argc != 0) + return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("unexpected argument(s) found, see --help")); return blsuki_cmd (ctxt, BLSUKI_UKI_CMD); } -- 2.47.3