git.ipfire.org Git - thirdparty/kernel/stable-queue.git/blob

   1 From 44b911e77793d686b481608770d0c55c18055ba0 Mon Sep 17 00:00:00 2001
   2 From: Jack Morgenstein <jackm@dev.mellanox.co.il>
   3 Date: Sun, 27 Nov 2016 19:20:52 +0200
   4 Subject: net/mlx4: Fix uninitialized fields in rule when adding promiscuous mode to device managed flow steering
   5
   6 From: Jack Morgenstein <jackm@dev.mellanox.co.il>
   7
   8 commit 44b911e77793d686b481608770d0c55c18055ba0 upstream.
   9
  10 In procedure mlx4_flow_steer_promisc_add(), several fields
  11 were left uninitialized in the rule structure.
  12 Correctly initialize these fields.
  13
  14 Fixes: 592e49dda812 ("net/mlx4: Implement promiscuous mode with device managed flow-steering")
  15 Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
  16 Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
  17 Signed-off-by: David S. Miller <davem@davemloft.net>
  18 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  19
  20 ---
  21  drivers/net/ethernet/mellanox/mlx4/mcg.c |    7 ++++++-
  22  1 file changed, 6 insertions(+), 1 deletion(-)
  23
  24 --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
  25 +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
  26 @@ -1464,7 +1464,12 @@ EXPORT_SYMBOL_GPL(mlx4_multicast_detach)
  27  int mlx4_flow_steer_promisc_add(struct mlx4_dev *dev, u8 port,
  28                                 u32 qpn, enum mlx4_net_trans_promisc_mode mode)
  29  {
  30 -       struct mlx4_net_trans_rule rule;
  31 +       struct mlx4_net_trans_rule rule = {
  32 +               .queue_mode = MLX4_NET_TRANS_Q_FIFO,
  33 +               .exclusive = 0,
  34 +               .allow_loopback = 1,
  35 +       };
  36 +
  37         u64 *regid_p;
  38
  39         switch (mode) {