]> git.ipfire.org Git - thirdparty/linux.git/commit
usb: ulpi: fix double free in ulpi_register_interface() error path
authorGuangshuo Li <lgs201920130244@gmail.com>
Wed, 1 Apr 2026 02:51:42 +0000 (10:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 07:36:56 +0000 (09:36 +0200)
commit01af542392b5d41fd659d487015a71f627accce3
tree48dc4cb838051114c724459a8504329b61cca900
parent33cfe0709b6bf1a7f1a16d5e8d65d003a71b6a21
usb: ulpi: fix double free in ulpi_register_interface() error path

When device_register() fails, ulpi_register() calls put_device() on
ulpi->dev.

The device release callback ulpi_dev_release() drops the OF node
reference and frees ulpi, but the current error path in
ulpi_register_interface() then calls kfree(ulpi) again, causing a
double free.

Let put_device() handle the cleanup through ulpi_dev_release() and
avoid freeing ulpi again in ulpi_register_interface().

Fixes: 289fcff4bcdb1 ("usb: add bus type for USB ULPI")
Cc: stable <stable@kernel.org>
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://patch.msgid.link/20260401025142.1398996-1-lgs201920130244@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/common/ulpi.c